refactor(forms): replace any with unknown in interop control value types#68356
Open
splincode wants to merge 1 commit intoangular:mainfrom
Open
refactor(forms): replace any with unknown in interop control value types#68356splincode wants to merge 1 commit intoangular:mainfrom
any with unknown in interop control value types#68356splincode wants to merge 1 commit intoangular:mainfrom
Conversation
kirjs
approved these changes
Apr 27, 2026
Contributor
|
Please update feat->refactor in the commit, so that we can merge it in the patch branch |
…e types - `CombinedControl.value` and `InteropNgControl.value` getter now return `unknown` instead of `any`, matching the actual `ReadonlyFieldState<unknown>` return type of `controlValue()`. - Remove redundant `as any` cast in `cvaControlCreate`: `parent` is typed as `FormField<unknown>`, so `state().controlValue` is `WritableSignal<unknown>` and accepts `unknown` directly.
f7fe404 to
ee852a7
Compare
any with unknown in interop control value typesany with unknown in interop control value types
Contributor
Author
|
@kirjs Thank you, fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
CombinedControl.valueandInteropNgControl.valuegetter now returnunknowninstead ofany, matching the actualReadonlyFieldState<unknown>return type ofcontrolValue()