Fix accumulating indentation in CREATE TABLE columns - #906
Open
ryanchou1994 wants to merge 1 commit into
Open
ryanchou1994 wants to merge 1 commit into
ryanchou1994 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE TABLEcolumns with constraints such asNOT NULLcan be split into severalIdentifierListgroups. Reindent currently anchors each group to its constraint, so each following column moves farther to the right. Anchor these lists to the column-definition parenthesis instead.The change is limited to space-based column alignment in
CREATE TABLE;indent_columns, tab indentation, nested function arguments, andCREATE TABLE ASretain their existing behavior. Tests cover several constraints, formatting twice, CTAS, and a following SELECT statement.Fixes #688.
pytest): 512 passed, 2 xfailed, 1 xpassed on Linux Python 3.13ruff)The original issue SQL, including its primary key, formats consistently. The reindent scaling benchmark passes for both the base and this change.