Skip to content

Fix crash reading return value in superseded callbacks - #2496

Merged
Kenzzer merged 1 commit into
alliedmodders:k/sourcehook_alternativefrom
Mikusch:khook-callback-crash
Jul 1, 2026
Merged

Kenzzer merged 1 commit into
alliedmodders:k/sourcehook_alternativefrom
Mikusch:khook-callback-crash

Conversation

@Mikusch

@Mikusch Mikusch commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

KHook::GetOriginalValuePtr() returns null when a pre callback supersedes the original call, so post callbacks that read it crashed.

@Kenzzer
Kenzzer merged commit e3d06ec into alliedmodders:k/sourcehook_alternative Jul 1, 2026
@Mikusch
Mikusch deleted the khook-callback-crash branch July 3, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants