feat(telemetry): CLI flow events - #243
Merged
Merged
Conversation
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
LorrisSaintGenez
requested review from
NatanTechofNY,
dylantientcheu and
pipeline1987
June 11, 2026 20:46
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 55 |
| Duplication | 35 |
TIP This summary will be updated as you push new changes.
LorrisSaintGenez
marked this pull request as ready for review
June 11, 2026 20:48
LorrisSaintGenez
marked this pull request as draft
June 11, 2026 21:48
…ogin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
LorrisSaintGenez
marked this pull request as ready for review
June 12, 2026 20:28
8bittitan
reviewed
Jun 15, 2026
| }() | ||
| select { | ||
| case <-done: | ||
| case <-time.After(3 * time.Second): |
Contributor
There was a problem hiding this comment.
nit: IMO we should make this a lot shorter even, like 500ms -> 1s at the worst. Or even keep it fire-and-forget as it was prior.
A healthy flush completes in tens of ms; the cap only matters when the endpoint is unreachable, where bailing out faster keeps the CLI snappy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
8bittitan
approved these changes
Jun 15, 2026
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
algolia 1.11.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * feat(open): add new dashboard shortcuts by @LorrisSaintGenez in algolia/cli#225 * feat(application): update/upgrade/downgrade/plans commands by @LorrisSaintGenez in algolia/cli#224 * docs: add npm install option to README by @tkrugg in algolia/cli#223 * feat(application): add name, tos and plan selection during application creation by @LorrisSaintGenez in algolia/cli#227 * feat(identify): send user data to identify after oauth flow by @LorrisSaintGenez in algolia/cli#228 * feat(application): more precise plan upgrade/downgrade direction by @LorrisSaintGenez in algolia/cli#226 * feat(telemetry): CLI flow events by @LorrisSaintGenez in algolia/cli#243 * feat: add auth get command by @levimichael in algolia/cli#253 * chore(api client): Upgrade Algolia Go API client by @tkrugg in algolia/cli#254 * fix: update 'auth get' to support refresh by @levimichael in algolia/cli#255 * feat(auth): Add token to `auth get` command by @levimichael in algolia/cli#257 ## New Contributors * @levimichael made their first contribution in algolia/cli#253 **Full Changelog**: https://github.com/algolia/cli/compare/v1.10.5...v1.11.0</pre> <p>View the full release notes at <a href="proxy.php?url=https%3A%2F%2Fgithub.com%2Falgolia%2Fcli%2Fpull%2F%3Ca+href%3D"https://github.com/algolia/cli/releases/tag/v1.11.0">https://github.com/algolia/cli/releases/tag/v1.11.0</a>.</p">https://github.com/algolia/cli/releases/tag/v1.11.0">https://github.com/algolia/cli/releases/tag/v1.11.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!13019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Foundations (#238)
Close()deferred inExecute()with a 3s timeout;NoOpTelemetryClientfallback on init failure.Trackwith custom properties + monotonicsequencecounter per invocation.events.go):Flow/Step/Direction/ErrorClassenums,FlowTracker, event name constants.Command Completedemitted before final flush; guard against orphan events whenPersistentPreRunEnever ran.Auth flow events (#239)
RunOAuthFlowemitsCLI Auth Started→ one terminal event (Completed/Aborted/Failed) withstep,duration_ms,error_class.Eventstruct + typed constructors + nil-safeTrackEvent(ctx, Event)helper.telemetrytest.RecordingClientfor flow event tests.Logout flow event (#242)
auth logoutemitsCLI Auth Logout(flow: logout) beforeClearToken().Identifyat logout.Application create + plan change flow events (#240)
application create:CLI Application Create Started→Completed/Aborted/Failedwithstep,region,plan,duration_ms,reason. Dry runs not tracked.application upgrade/downgrade:CLI Application Plan Change *withdirection,from_plan,to_plan.Abortedcarries areason(declined_terms/cancelled/billing_required/already_on_plan/no_candidates).Env header (#241)
X-Algolia-CLI-Env: prod(semver build) ordev(source build). Transport clones the request.//v1/batch).Test
Go on the CLI Segment debugger: https://app.segment.com/algolia-app/sources/segment_cli_dev/debugger
Then try the following commands. You should see the events being logged into Segment.
sequenceproperty + timestamp combo indicate the real order of events (Segment sometimes shows events in the wrong order)GROUT-349
GROUT-351