Skip to content

New features and bug fixes - #21

Closed
eemmiirr wants to merge 3 commits into
alexec:masterfrom
eemmiirr:new-features
Closed

eemmiirr wants to merge 3 commits into
alexec:masterfrom
eemmiirr:new-features

Conversation

@eemmiirr

@eemmiirr eemmiirr commented Apr 7, 2015

Copy link
Copy Markdown
Contributor

Fixed couple of issues.
Please merge after docker-java/docker-java#194 is merged.
The same bug exists in the docker-java library

@alexec

alexec commented Apr 8, 2015

Copy link
Copy Markdown
Owner

OK. I've cherry picked your changes as they could not be merged normally. Can you check that the master version works for you?

@eemmiirr

eemmiirr commented Apr 8, 2015

Copy link
Copy Markdown
Contributor Author

Actually it won't work since the PR above was merged into 1.1.1-SNAPSHOT of docker-java library. The bug was also there present which enforces the deletion of images regardless of what is supplied. So we have to wait until it's released

@eemmiirr

eemmiirr commented Apr 8, 2015

Copy link
Copy Markdown
Contributor Author

Btw this has to be merged too eemmiirr@e2a8703 to fix the bug when naming images.

When the image is built it's tagged with one name. During the start phase the plugin tries to find the image by some other name which results that is never found and rebuild over again

@alexec

alexec commented Apr 9, 2015

Copy link
Copy Markdown
Owner

HI,

I think I have fixed that by modifying the imageExists method. I'm running a bunch of tests before releasing now.

Alex

@eemmiirr

eemmiirr commented Apr 9, 2015

Copy link
Copy Markdown
Contributor Author

Hi,

it works perfectly except that it removes always the intermediate images. You have to wait until the docker-java library with the patch is released

@alexec alexec closed this Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants