Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

Add pacmd set-sink wrapper module - #130

Closed
c4pQ wants to merge 2 commits into
albertlauncher:masterfrom
c4pQ:master
Closed

c4pQ wants to merge 2 commits into
albertlauncher:masterfrom
c4pQ:master

Conversation

@c4pQ

@c4pQ c4pQ commented Aug 10, 2022

Copy link
Copy Markdown

No description provided.

Comment thread pacmd/__init__.py Outdated
import subprocess
from albert import *

__title__ = "Pulseaudio cmd"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for the "cmd"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Comment thread pacmd/__init__.py Outdated

__title__ = "Pulseaudio cmd"
__version__ = "0.1.0"
__triggers__ = "pacmd "

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd tend to use just pa

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

Comment thread pacmd/__init__.py Outdated
__authors__ = "c4pQ"
__exec_deps__ = ['pacmd']

iconPath = iconLookup('audio-headphones')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/master/pulseaudio-text.svg i dunno if we can expect that 'pulseaudio-text' is on every system but id rather use this one

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow didn't see it
and if think of this extension as of starting point for pulseaudio automation, this image is even better

@ManuelSchneid3r

ManuelSchneid3r commented Oct 8, 2022

Copy link
Copy Markdown
Member

Neat. But i dont see the need to be too narrow. This is basically a PA wrapper. I dont expect you to wrap the entire api. This could serve as a starting point for others who need futher functionality.

@c4pQ

c4pQ commented Oct 19, 2022

Copy link
Copy Markdown
Author

Added requested changes

@ManuelSchneid3r

Copy link
Copy Markdown
Member

0.18 is out. please check the new api https://github.com/albertlauncher/plugins/blob/master/python/README.md

@ManuelSchneid3r

Copy link
Copy Markdown
Member

@c4pQ are you still interested in getting this plugin upstream?

@ManuelSchneid3r

Copy link
Copy Markdown
Member

I'll close this one due to the conflicts. Note that this has no further implication for me but to be able to work with the PR section in this repo efficiently. It is quite exhausting to keep track of the few active PRs between dozens of stale PRs. Please reopen or open a new PR if you are ready to merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants