Validate frequency arg for ParallelBus to prevent crash on 0 - #11041
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds input validation to the paralleldisplaybus.ParallelBus Python constructor to prevent a hard crash on ESP32-S3 when frequency=0 is passed, by requiring frequency >= 1.
Changes:
- Validate
frequencyusingmp_arg_validate_int_min(..., 1, ...)inParallelBus.__init__. - Pass the validated
frequencyvalue through to both sequential (data0) and non-sequential (data_pins) constructor paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dhalbert
force-pushed
the
parallelbus-freq-validation
branch
from
June 2, 2026 00:20
083c458 to
d90f4f3
Compare
Collaborator
Author
|
I didn't mean to ask Copilot for a review. That was a mouse-click error. But I did the cast anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParallelBuswas not validating thefrequencyarg. If it was0, there was an internal error in ESP-IDF (probably a divide by zero), which caused a hard crash. Requirefrequencyto be >=1.Tested on a UM ProS3 with the original test code.