Update buffer operator terminal event handling - #2474
Open
shariarriday wants to merge 1 commit into
Open
shariarriday wants to merge 1 commit into
shariarriday wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates buffer backpressure and terminal-event handling so upstream reads follow downstream demand.
Changes:
- Tracks in-flight items and limits upstream requests.
- Defers terminal events when buffered items lack demand.
- Adds documentation and extensive behavior tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
manual/core/DataFlows.rst |
Documents demand and terminal semantics. |
libcaf_core/caf/flow/op/buffer.hpp |
Implements demand-aware pulling and terminal disposal. |
libcaf_core/caf/flow/op/buffer.test.cpp |
Tests demand, terminal, disposal, and interval behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2474 +/- ##
==========================================
+ Coverage 72.98% 73.20% +0.21%
==========================================
Files 652 656 +4
Lines 31341 31433 +92
Branches 3444 3446 +2
==========================================
+ Hits 22875 23011 +136
+ Misses 6517 6463 -54
- Partials 1949 1959 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shariarriday
force-pushed
the
topic/shariarriday/buffer-op-terminal-events
branch
from
August 29, 2026 17:15
ddc6397 to
51de204
Compare
shariarriday
force-pushed
the
topic/shariarriday/buffer-op-terminal-events
branch
from
August 30, 2026 10:11
51de204 to
c9ef450
Compare
shariarriday
marked this pull request as ready for review
August 30, 2026 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #2471
This PR slightly reworks how buffer handles demand. Buffer does not request any value from source until the observer provides demand. Previously, buffer operator requested from source irrespective of demand from observer. Changing this behavior also resolves terminal event handling issue for this operator.