Conversation
The tool embeds a given sequence of Wasm modules in place of the Wasm modules already present in a given JS file. Alternatively, with the --extract option, it extracts the embedded modules from the JS file and writes them as standalone Wasm files. This replaces the embed_wasms.py and extract_wasms.py scripts, reusing the C++ embedded module parsing logic added for wasm-reduce --js. The differences in behavior from the replaced scripts are that the new tool 1) can accept .wat files as input, assembling them before embedding, and 2) does not modify the original source when extracting modules and does not rely on a sentinel placeholder to determine where to embed new modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool embeds a given sequence of Wasm modules in place of the Wasm modules already present in a given JS file. Alternatively, with the --extract option, it extracts the embedded modules from the JS file and writes them as standalone Wasm files. This replaces the embed_wasms.py and extract_wasms.py scripts, reusing the C++ embedded module parsing logic added for wasm-reduce --js. The differences in behavior from the replaced scripts are that the new tool 1) can accept .wat files as input, assembling them before embedding, and 2) does not modify the original source when extracting modules and does not rely on a sentinel placeholder to determine where to embed new modules.