Architecture.md improvements - #254
Merged
SamuelBellomo merged 20 commits intoApr 6, 2021
Merged
SamuelBellomo merged 20 commits into
SamuelBellomo merged 20 commits into
Conversation
lkrell
self-requested a review
April 6, 2021 14:37
|
|
lkrell
reviewed
Apr 6, 2021
lkrell
left a comment
Contributor
There was a problem hiding this comment.
Nice additions! Some edits to consider! One definitely may want to be changed for NetworkedVars to NetworkVariables.
Co-authored-by: Lori Krell <76010626+lkrell@users.noreply.github.com>
Co-authored-by: Lori Krell <76010626+lkrell@users.noreply.github.com>
Co-authored-by: Lori Krell <76010626+lkrell@users.noreply.github.com>
Co-authored-by: Lori Krell <76010626+lkrell@users.noreply.github.com>
Co-authored-by: Lori Krell <76010626+lkrell@users.noreply.github.com>
Co-authored-by: Lori Krell <76010626+lkrell@users.noreply.github.com>
Co-authored-by: Lori Krell <76010626+lkrell@users.noreply.github.com>
Co-authored-by: Lori Krell <76010626+lkrell@users.noreply.github.com>
Co-authored-by: Sam Bellomo <71790295+SamuelBellomo@users.noreply.github.com>
Co-authored-by: Sam Bellomo <71790295+SamuelBellomo@users.noreply.github.com>
Co-authored-by: Sam Bellomo <71790295+SamuelBellomo@users.noreply.github.com>
Co-authored-by: Sam Bellomo <71790295+SamuelBellomo@users.noreply.github.com>
…logies/com.unity.multiplayer.samples.coop into feature/architecture-md-improvements # Conflicts: # ARCHITECTURE.md
lkrell
previously approved these changes
Apr 6, 2021
lkrell
approved these changes
Apr 6, 2021
SamuelBellomo
approved these changes
Apr 6, 2021
SamuelBellomo
added a commit
that referenced
this pull request
May 19, 2021
* main: Adding suggested changes Uploading pull-request-template docs: License UCL update and changelog additions (#304) Correction for stealth state, should use bool, not byte (#263) Create third-party contributions file (#262) Update README.md in package (#260) Architecture.md improvements (#254) docs: Changelog and Third Party for 0.1.0 (#233) Update LICENSE.md Update LICENSE.md Update LICENSE.md adding initial codeowners file (sam as global) (#258) Update readme (#256) Adding missing space project name update (#245) quick fix for missing TGA # Conflicts: # Assets/BossRoom/Scripts/Client/Game/Character/ClientCharacterVisualization.cs # Assets/BossRoom/Scripts/Server/Game/Action/StealthModeAction.cs # Assets/BossRoom/Scripts/Server/Game/Character/AIBrain.cs # Packages/com.unity.multiplayer.samples.coop/CHANGELOG.md # ProjectSettings/ProjectSettings.asset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.