Skip to content

Implemented Fast Inverse Sqrt Method - #3199

Closed
ghost wants to merge 3 commits into
masterfrom
unknown repository
Closed

Implemented Fast Inverse Sqrt Method#3199
ghost wants to merge 3 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 23, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

Describe your change:

  • [x ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • [x ] This pull request is all my own work -- I have not plagiarized.
  • [x ] I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x] All new Java files are placed inside an existing directory.
  • [x ] All filenames are in all uppercase characters with no spaces or dashes.
  • [ x] All functions and variable names follow Java naming conventions.
  • [ x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost
ghost requested review from siriak and yanglbme as code owners July 23, 2022 12:35
siriak
siriak requested changes Jul 24, 2022
View reviewed changes

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you add some automated tests as well?

@ghost

ghost commented Jul 24, 2022

Copy link
Copy Markdown
Author

The code looks good, could you add some automated tests as well?

I have just pushed my latest commit that consists of automated tests between both methods

@siriak

siriak commented Jul 25, 2022

Copy link
Copy Markdown
Member

Take a look at the files here https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms, main is an entry point and won't be run by a testing framework. It would help if you had JUnit tests https://www.vogella.com/tutorials/JUnit/article.html

@siddhant2002

siddhant2002 commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

Can I work under this issue?

@siddhant2002

siddhant2002 commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

@siriak Please check the pr

@siriak

siriak commented Aug 23, 2022

Copy link
Copy Markdown
Member

@siddhant2002 which PR?

@siriak siriak closed this in 2ffcff1 Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siriak @siddhant2002