Scope patches commit provenance exception - #28
Closed
Wenxin Jiang (Wenxin-Jiang) wants to merge 2 commits into
Closed
Wenxin Jiang (Wenxin-Jiang) wants to merge 2 commits into
Wenxin Jiang (Wenxin-Jiang) wants to merge 2 commits into
Conversation
Use a read-only PR bot token for Patchpedia lookups in depscan. Keep repository-token authentication for other audit consumers. Assisted-by: Codex:GPT-6
Audit the three depscan patches workflows separately so their private commit lookup can be omitted without changing other inputs. Preserve failures from both scans and remove App credentials. Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Codex:GPT-6
The required audit for SocketDev/depscan#26088 fails because its repository token cannot inspect private Patchpedia commit ancestry. Apply the approved
impostor-commitexception only to three patches workflows, without requiring a PR-bot key or changing the audit for other inputs.When running in depscan with
.github/zizmor-patches.ymlpresent, scan a temporary copy of the complete.githubtree with the three patches workflows removed, then scan those original files using the explicit exception config. Both scans run and either failure fails the job. Root audit configuration is copied for the normal scan; composite actions and Dependabot remain covered. Other repositories, and depscan revisions without the exception config, retain the original scan.The exception applies to
deploy-patches-staging.yaml,deploy-patches-prod.yaml, andpatches-compatibility.yaml. Their config in depscan preserves existing repository policy and additionally disablesimpostor-commit. This omits provenance checks for all action references in those three files, not only Patchpedia. All other rules retain existing policy, and other inputs retain provenance checks. SHA pins and deployment validation remain unchanged.No App-token step, App-secret warning exception, repository write permission, audit-wide suppression or offline audit mode is introduced.
Validation
impostor-commit: disable: true.git diff --checkpasses. Independent review approved the partition and failure propagation.Enablement
Merge this central workflow change and ensure depscan contains its scoped config, then trigger a fresh required audit on depscan#26088. The exception does not take effect before both are present. Reusable-workflow sharing remains a separate prerequisite. No credentials or repository settings were changed.