Feature dev423 new osrm client - #14
Merged
Merged
Conversation
rfjaimes-simpli
left a comment
Collaborator
There was a problem hiding this comment.
solo algunos comentarios
| // low fmv | ||
| double speedRate = 2; | ||
| String country = "CL"; | ||
| String country = "AD"; |
Collaborator
There was a problem hiding this comment.
solo por curiosidad, porque se cambio este country?
Contributor
Author
There was a problem hiding this comment.
Porque cuando estaba haciendo las pruebas internas tenía el mapa de andorra cargado en osrm
|
|
||
| // token | ||
| String token = "None"; | ||
| String token = "Token b926b46ddb8f5efab66693961369e0116712adde"; |
rfjaimes-simpli
approved these changes
Aug 28, 2025
Comment on lines
+52
to
+55
| paramsString = addParamString(paramsString, "speedRate", Double.toString(request.getSpeedRate())); | ||
| paramsString = addParamString(paramsString, "country", request.getCountry()); | ||
| paramsString = addParamString(paramsString, "start_time", request.getStartTime()); | ||
| paramsString = addParamString(paramsString, "vehicleSubType", request.getVehicleSubType()); |
Collaborator
There was a problem hiding this comment.
esto no estaba enviandose por otro lado? la idea es quede dinamico
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Falta abordar el tema del envío de los parámetros restriction