Detect Simulator using pragma. Fixes/improves Issue #834 - #835
Open
JoeFerrucci wants to merge 1 commit into
Open
JoeFerrucci wants to merge 1 commit into
JoeFerrucci wants to merge 1 commit into
Conversation
Use TARGET_IPHONE_SIMULATOR instead of checking for string prefix. Fixed SVGKit#834
Contributor
|
I'm sure we originally had this, and there was some reason it didn't work ... maybe it was a bug in Xcode that is now fixed? ... If I remember correctly: Xcode would mark this as true "always" when you tried to auto-build a merged binary .so file (which our custom build script does). |
Author
I’ll test it in Release and on device and if it returns true always, I’ll close this. |
Contributor
|
Testing the #define on its own won't do much - you'd need to test it
while running the build-script, because xcode runs the build-script
with different env-variables compared to just running a basic build
directly.
(Assuming the build script is still in-use! I think it's still there,
making dual-binaries that work in both simulator and in store - but I
haven't looked at it in years, so maybe it's been
deleted/removed/replaced by now!)
…On Fri, 28 Jun 2024 at 17:38, Joe Ferrucci ***@***.***> wrote:
I'm sure we originally had this, and there was some reason it didn't work ... maybe it was a bug in Xcode that is now fixed? ... If I remember correctly: Xcode would mark this as true "always" when you tried to auto-build a merged binary .so file (which our custom build script does).
I’ll test it in Release and on device and if it returns true always, I’ll close this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use TARGET_IPHONE_SIMULATOR instead of checking for string prefix.
Fixes/improves #834