Fix imports - #822
Fix imports#822g4rb4g3 wants to merge 9 commits into
Conversation
|
Changing it to "Dom*" achieves nothing - there are other libraries that use that name too. This patch would have to change everything to an SVGKit-specific prefix. Otherwise you're not solving the problem (and note: this change breaks all existing code that references anything in the DOM, for all existing apps: it's a massive change). We've discussed this in the past, and the ideal is to instead move the DOM code into a separate library. At the time, there were NO open-source libraries providing good-quality DOM on Apple platforms (maybe there are now?). Until someone is willing to do that (and test it thoroughly), the minimum change is rename everything with an SVGKit prefix (to prevent name clashes in future), but then it will have to be renamed back again if/when someone migrates this to use external DOM library(ies). (Unless Apple has finally added support for namespaces to ObjC? Which would make everyone's lives much, much, easier!) |
We use SVGKit in a react-native project that comes with Yoga which brings its own Node.h that SVGKit tries to make use of then. This makes builds fail obviously. 😢 I also added another import fix for CocoaLumberjack that @troZee did. :)
Would be great if this could get merged here so we can switch back to the official repo. 🚀 Thanks!