Remove spaces from paths, fix xcodeprojs - #723
Closed
dostrander wants to merge 1 commit into
Closed
dostrander wants to merge 1 commit into
dostrander wants to merge 1 commit into
Conversation
Contributor
|
That is WILD. The idea that anyone wouldnt support spaces in paths in this
century is pretty amazing, let alone 2021!
... I wonder what bazel does when it sees other classic Mac paths, eg
including colons in filenames (not common but not particularly rare on Mac,
since it's been supported for decades - I see it a lot with files edited by
writers and graphic designers).
This late in the project it seems pretty disruptive to make the folder
structure harder to read just to workaround a bug someone else should
REALLY fix in their code. Spaces in folders are a very common thing in Mac
projects, and I strongly suspect that if we do this patch it will only
break again in near.future when a new contributor adds a new folder,
unaware of the problem.
So I'm leaning towards rejecting this one. Does anyone else feel strongly
either way?
…On 28 June 2021 18:16:26 "Derek Ostrander (derko)" ***@***.***> wrote:
**Why?**
This isn't a problem with SVGKit per se, however with bazel's
runfiles they do not currently support spaces and does not seem to be on
their roadmap to support it currently
(bazelbuild/bazel#4327).
If this is not something you are interested in changing in your repo
that's okay and we can likely do a work around Please let me know!
You can view, comment on, or merge this pull request online at:
#723
-- Commit Summary --
* Remove spaces from paths, fix xcodeprojs
-- File Changes --
M SVGKit-iOS.xcodeproj/project.pbxproj (50)
R Source/AppKitAdditions/SVGKImageRep.h (0)
R Source/AppKitAdditions/SVGKImageRep.m (0)
R Source/DOMClasses/CoreDOM/AppleSucksDOMImplementation.h (0)
R Source/DOMClasses/CoreDOM/AppleSucksDOMImplementation.m (0)
R Source/DOMClasses/CoreDOM/Attr.h (0)
R Source/DOMClasses/CoreDOM/Attr.m (0)
R Source/DOMClasses/CoreDOM/CDATASection.h (0)
R Source/DOMClasses/CoreDOM/CDATASection.m (0)
R Source/DOMClasses/CoreDOM/CSSPrimitiveValue.h (0)
R Source/DOMClasses/CoreDOM/CSSPrimitiveValue.m (0)
R Source/DOMClasses/CoreDOM/CSSPrimitiveValue_ConfigurablePixelsPerInch.h (0)
R Source/DOMClasses/CoreDOM/CSSRule.h (0)
R Source/DOMClasses/CoreDOM/CSSRule.m (0)
R Source/DOMClasses/CoreDOM/CSSRuleList+Mutable.h (0)
R Source/DOMClasses/CoreDOM/CSSRuleList.h (0)
R Source/DOMClasses/CoreDOM/CSSRuleList.m (0)
R Source/DOMClasses/CoreDOM/CSSStyleDeclaration.h (0)
R Source/DOMClasses/CoreDOM/CSSStyleDeclaration.m (0)
R Source/DOMClasses/CoreDOM/CSSStyleRule.h (0)
R Source/DOMClasses/CoreDOM/CSSStyleRule.m (0)
R Source/DOMClasses/CoreDOM/CSSStyleSheet.h (0)
R Source/DOMClasses/CoreDOM/CSSStyleSheet.m (0)
R Source/DOMClasses/CoreDOM/CSSValue.h (0)
R Source/DOMClasses/CoreDOM/CSSValue.m (0)
R Source/DOMClasses/CoreDOM/CSSValueList.h (0)
R Source/DOMClasses/CoreDOM/CSSValueList.m (0)
R Source/DOMClasses/CoreDOM/CSSValue_ForSubclasses.h (0)
R Source/DOMClasses/CoreDOM/CharacterData.h (0)
R Source/DOMClasses/CoreDOM/CharacterData.m (0)
R Source/DOMClasses/CoreDOM/Comment.h (0)
R Source/DOMClasses/CoreDOM/Comment.m (0)
R Source/DOMClasses/CoreDOM/DOMGlobalSettings.h (0)
R Source/DOMClasses/CoreDOM/DOMHelperUtilities.h (0)
R Source/DOMClasses/CoreDOM/DOMHelperUtilities.m (0)
R Source/DOMClasses/CoreDOM/Document+Mutable.h (0)
R Source/DOMClasses/CoreDOM/Document.h (0)
R Source/DOMClasses/CoreDOM/Document.m (0)
R Source/DOMClasses/CoreDOM/DocumentCSS.h (0)
R Source/DOMClasses/CoreDOM/DocumentFragment.h (0)
R Source/DOMClasses/CoreDOM/DocumentFragment.m (0)
R Source/DOMClasses/CoreDOM/DocumentStyle.h (0)
R Source/DOMClasses/CoreDOM/DocumentType.h (0)
R Source/DOMClasses/CoreDOM/DocumentType.m (0)
R Source/DOMClasses/CoreDOM/Element.h (0)
R Source/DOMClasses/CoreDOM/Element.m (0)
R Source/DOMClasses/CoreDOM/EntityReference.h (0)
R Source/DOMClasses/CoreDOM/EntityReference.m (0)
R Source/DOMClasses/CoreDOM/MediaList.h (0)
R Source/DOMClasses/CoreDOM/MediaList.m (0)
R Source/DOMClasses/CoreDOM/NamedNodeMap.h (0)
R Source/DOMClasses/CoreDOM/NamedNodeMap.m (0)
R Source/DOMClasses/CoreDOM/NamedNodeMap_Iterable.h (0)
R Source/DOMClasses/CoreDOM/Node+Mutable.h (0)
R Source/DOMClasses/CoreDOM/Node.h (0)
R Source/DOMClasses/CoreDOM/Node.m (0)
R Source/DOMClasses/CoreDOM/NodeList+Mutable.h (0)
R Source/DOMClasses/CoreDOM/NodeList.h (0)
R Source/DOMClasses/CoreDOM/NodeList.m (0)
R Source/DOMClasses/CoreDOM/ProcessingInstruction.h (0)
R Source/DOMClasses/CoreDOM/ProcessingInstruction.m (0)
R Source/DOMClasses/CoreDOM/StyleSheet.h (0)
R Source/DOMClasses/CoreDOM/StyleSheet.m (0)
R Source/DOMClasses/CoreDOM/StyleSheetList+Mutable.h (0)
R Source/DOMClasses/CoreDOM/StyleSheetList.h (0)
R Source/DOMClasses/CoreDOM/StyleSheetList.m (0)
R Source/DOMClasses/CoreDOM/Text.h (0)
R Source/DOMClasses/CoreDOM/Text.m (0)
R Source/DOMClasses/SVG-DOM/SVGAngle.h (0)
R Source/DOMClasses/SVG-DOM/SVGAngle.m (0)
R Source/DOMClasses/SVG-DOM/SVGAnimatedPreserveAspectRatio.h (0)
R Source/DOMClasses/SVG-DOM/SVGAnimatedPreserveAspectRatio.m (0)
R Source/DOMClasses/SVG-DOM/SVGClipPathElement.h (0)
R Source/DOMClasses/SVG-DOM/SVGClipPathElement.m (0)
R Source/DOMClasses/SVG-DOM/SVGDefsElement.h (0)
R Source/DOMClasses/SVG-DOM/SVGDefsElement.m (0)
R Source/DOMClasses/SVG-DOM/SVGDocument.h (0)
R Source/DOMClasses/SVG-DOM/SVGDocument.m (0)
R Source/DOMClasses/SVG-DOM/SVGDocument_Mutable.h (0)
R Source/DOMClasses/SVG-DOM/SVGElementInstance.h (0)
R Source/DOMClasses/SVG-DOM/SVGElementInstance.m (0)
R Source/DOMClasses/SVG-DOM/SVGElementInstanceList.h (0)
R Source/DOMClasses/SVG-DOM/SVGElementInstanceList.m (0)
R Source/DOMClasses/SVG-DOM/SVGElementInstanceList_Internal.h (0)
R Source/DOMClasses/SVG-DOM/SVGElementInstance_Mutable.h (0)
R Source/DOMClasses/SVG-DOM/SVGFitToViewBox.h (0)
R Source/DOMClasses/SVG-DOM/SVGGElement.h (0)
R Source/DOMClasses/SVG-DOM/SVGGElement.m (0)
R Source/DOMClasses/SVG-DOM/SVGHelperUtilities.h (0)
R Source/DOMClasses/SVG-DOM/SVGHelperUtilities.m (0)
R Source/DOMClasses/SVG-DOM/SVGLength.h (0)
R Source/DOMClasses/SVG-DOM/SVGLength.m (0)
R Source/DOMClasses/SVG-DOM/SVGMatrix.h (0)
R Source/DOMClasses/SVG-DOM/SVGMatrix.m (0)
R Source/DOMClasses/SVG-DOM/SVGNumber.h (0)
R Source/DOMClasses/SVG-DOM/SVGPoint.h (0)
R Source/DOMClasses/SVG-DOM/SVGPoint.m (0)
R Source/DOMClasses/SVG-DOM/SVGPreserveAspectRatio.h (0)
R Source/DOMClasses/SVG-DOM/SVGPreserveAspectRatio.m (0)
R Source/DOMClasses/SVG-DOM/SVGRect.h (0)
R Source/DOMClasses/SVG-DOM/SVGRect.m (0)
R Source/DOMClasses/SVG-DOM/SVGSVGElement_Mutable.h (0)
R Source/DOMClasses/SVG-DOM/SVGStylable.h (0)
R Source/DOMClasses/SVG-DOM/SVGTextContentElement.h (0)
R Source/DOMClasses/SVG-DOM/SVGTextContentElement.m (0)
R Source/DOMClasses/SVG-DOM/SVGTextPositioningElement.h (0)
R Source/DOMClasses/SVG-DOM/SVGTextPositioningElement.m (0)
R Source/DOMClasses/SVG-DOM/SVGTextPositioningElement_Mutable.h (0)
R Source/DOMClasses/SVG-DOM/SVGTransform.h (0)
R Source/DOMClasses/SVG-DOM/SVGTransform.m (0)
R Source/DOMClasses/SVG-DOM/SVGTransformable.h (0)
R Source/DOMClasses/SVG-DOM/SVGUnitTypes.h (0)
R Source/DOMClasses/SVG-DOM/SVGUseElement.h (0)
R Source/DOMClasses/SVG-DOM/SVGUseElement.m (0)
R Source/DOMClasses/SVG-DOM/SVGUseElement_Mutable.h (0)
R Source/DOMClasses/SVG-DOM/SVGViewSpec.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/BaseClassForAllSVGBasicShapes.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/BaseClassForAllSVGBasicShapes.m (0)
R
Source/DOMClasses/UnportedOrPartialDOM/BaseClassForAllSVGBasicShapes_ForSubclasses.h
(0)
R Source/DOMClasses/UnportedOrPartialDOM/ConverterSVGToCALayer.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGCircleElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGCircleElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGDescriptionElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGDescriptionElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGElement_ForParser.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGEllipseElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGEllipseElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGGradientElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGGradientElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGGradientStop.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGGradientStop.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGGroupElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGGroupElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGImageElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGImageElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGLineElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGLineElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGLinearGradientElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGLinearGradientElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGPathElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGPathElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGPolygonElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGPolygonElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGPolylineElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGPolylineElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGRadialGradientElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGRadialGradientElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGRectElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGRectElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGSVGElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGSVGElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGStyleCatcher.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGStyleElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGStyleElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGSwitchElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGSwitchElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGTextElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGTextElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGTitleElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/SVGTitleElement.m (0)
R Source/DOMClasses/UnportedOrPartialDOM/TinySVGTextAreaElement.h (0)
R Source/DOMClasses/UnportedOrPartialDOM/TinySVGTextAreaElement.m (0)
R Source/FoundationAdditions/NSCharacterSet+SVGKExtensions.h (0)
R Source/FoundationAdditions/NSCharacterSet+SVGKExtensions.m (0)
R Source/FoundationAdditions/NSData+NSInputStream.h (0)
R Source/FoundationAdditions/NSData+NSInputStream.m (0)
R Source/Parsers/ParserExtensions/SVGKParserDOM.h (0)
R Source/Parsers/ParserExtensions/SVGKParserDOM.m (0)
R Source/Parsers/ParserExtensions/SVGKParserDefsAndUse.h (0)
R Source/Parsers/ParserExtensions/SVGKParserDefsAndUse.m (0)
R Source/Parsers/ParserExtensions/SVGKParserGradient.h (0)
R Source/Parsers/ParserExtensions/SVGKParserGradient.m (0)
R Source/Parsers/ParserExtensions/SVGKParserPatternsAndGradients.h (0)
R Source/Parsers/ParserExtensions/SVGKParserPatternsAndGradients.m (0)
R Source/Parsers/ParserExtensions/SVGKParserSVG.h (0)
R Source/Parsers/ParserExtensions/SVGKParserSVG.m (0)
R Source/Parsers/ParserExtensions/SVGKParserStyles.h (0)
R Source/Parsers/ParserExtensions/SVGKParserStyles.m (0)
R Source/QuartzCoreAdditions/CALayer+RecursiveClone.h (0)
R Source/QuartzCoreAdditions/CALayer+RecursiveClone.m (0)
R Source/QuartzCoreAdditions/CALayerWithChildHitTest.h (0)
R Source/QuartzCoreAdditions/CALayerWithChildHitTest.m (0)
R Source/QuartzCoreAdditions/CALayerWithClipRender.h (0)
R Source/QuartzCoreAdditions/CALayerWithClipRender.m (0)
R Source/QuartzCoreAdditions/CAShapeLayerWithClipRender.h (0)
R Source/QuartzCoreAdditions/CAShapeLayerWithClipRender.m (0)
R Source/QuartzCoreAdditions/CAShapeLayerWithHitTest.h (0)
R Source/QuartzCoreAdditions/CAShapeLayerWithHitTest.m (0)
R Source/QuartzCoreAdditions/CGPathAdditions.h (0)
R Source/QuartzCoreAdditions/CGPathAdditions.m (0)
R Source/QuartzCoreAdditions/SVGGradientLayer.h (0)
R Source/QuartzCoreAdditions/SVGGradientLayer.m (0)
R Source/QuartzCoreAdditions/SVGKLayer.h (0)
R Source/QuartzCoreAdditions/SVGKLayer.m (0)
R Source/UIKitAdditions/SVGKFastImageView.h (0)
R Source/UIKitAdditions/SVGKFastImageView.m (0)
R Source/UIKitAdditions/SVGKImageView.h (0)
R Source/UIKitAdditions/SVGKImageView.m (0)
R Source/UIKitAdditions/SVGKLayeredImageView.h (0)
R Source/UIKitAdditions/SVGKLayeredImageView.m (0)
-- Patch Links --
https://github.com/SVGKit/SVGKit/pull/723.patch
https://github.com/SVGKit/SVGKit/pull/723.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#723
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This purely changes the paths to the source files. The only "code" that has been changed is the xcodeproj's xml to represent the updated paths.
Why?
This isn't a problem with SVGKit per se, however with bazel's runfiles they do not currently support spaces and does not seem to be on their roadmap to support it currently (bazelbuild/bazel#4327). This is the only reason we need to have this change in.
If this is not something you are interested in changing in your repo that's okay and we can likely do a work around Please let me know!