Skip to content

add_svgelement_transform - #658

Open
lichentao wants to merge 2 commits into
SVGKit:3.xfrom
lichentao:svg_element_transform
Open

lichentao wants to merge 2 commits into
SVGKit:3.xfrom
lichentao:svg_element_transform

Conversation

@lichentao

Copy link
Copy Markdown

Description:
element and sub element has implement transform, svg can Apply transform ? for test ok

Example:

@adamgit

adamgit commented Nov 25, 2019

Copy link
Copy Markdown
Contributor

The following elements should have "SVGTransformable":

SVG, G, A, DEFS, USE, IMAGE, SWITCH, PATH, RECT, CIRCLE, ELLIPSE, LINE, POLYLINE, POLYGON, TEXT

It appears to be missing from:

SVG, DEFS, SWITCH

Please could you add this change to the SVGDefsElement.* and SVGSwitchEleemnt.* as well, so that all places are now correct?

Also, please include the one-line comment in the .m files where you have the line "@synthesize transform;" -- all the other classes have the comment:

""synthesize transform; // each SVGElement subclass that conforms to protocol "SVGTransformable" has to re-synthesize this to work around bugs in Apple's Objective-C 2.0 design that don't allow @properties to be extended by categories / protocols"

...this will make sure no-one accidentally deletes that @synthesize line (unless it is no longer necessary? I haven't checked recently)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants