Conversation
Contributor
|
Someone made the same change recently, and I requested that they either change the method name too (since it CANNOT have this return type with that name!) and/or change the implementation to return void. So, either: SVGKParser* parserWithContentsOfFileAsynchronously: or void asynchronouslyParseImageWithContentsOfFile: ...the former would have least impact on existing code, and so I think is better? (but I'd appreciate input from others on this - either way it will definitely impact existing projects) |
Author
|
An option could be to deprecate the current method, by leaving the API as is but always return nil.
Then add the "SVGKParser* parserWithContentsOfFileAsynchronously:" method that replaces the former (as put in the deprecation message).
Regards, Werner
… On 12 Dec 2016, at 12:02, adamgit ***@***.***> wrote:
Someone made the same change recently, and I requested that they either change the method name too (since it CANNOT have this return type with that name!) and/or change the implementation to return void.
So, either:
SVGKParser* parserWithContentsOfFileAsynchronously:
or
void asynchronouslyParseImageWithContentsOfFile:
...the former would have least impact on existing code, and so I think is better? (but I'd appreciate input from others on this - either way it will definitely impact existing projects)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#502 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcihdHv232c4BHuc9__o4JcFDTbdyfnks5rHSmygaJpZM4LKZ4z>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.