Skip to content

Move dependencies to workspace for common crate#7771

Merged
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-common
May 5, 2026
Merged

Move dependencies to workspace for common crate#7771
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-common

Conversation

@fanninpm
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm commented May 4, 2026 •
edited by coderabbitai Bot
Loading

cc @ShaharNaveh

Summary by CodeRabbit

  • Chores
    • Centralized workspace dependency management to improve build consistency and simplify version control across the project.
    • Added and aligned new workspace-managed dependency entries to ensure consistent builds across crates.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: f4077671-3a00-40ff-b158-adbc2a1e1139

📥 Commits

Reviewing files that changed from the base of the PR and between 1e9bc0d and 0ee5db4.

📒 Files selected for processing (2)
  • Cargo.toml
  • crates/common/Cargo.toml
✅ Files skipped from review due to trivial changes (1)
  • crates/common/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • Cargo.toml
📝 Walkthrough

Walkthrough

This PR adds lock_api and siphasher to the root Cargo.toml [workspace.dependencies] and updates crates/common/Cargo.toml to reference lock_api, siphasher, and num-complex via { workspace = true } instead of inline version pins. No public Rust APIs changed.

Changes

Workspace Dependency Consolidation

Layer / File(s) Summary
Workspace Dependency Definitions
Cargo.toml		 Inserted lock_api = "0.4" and siphasher = "1" into [workspace.dependencies].
Crate Dependency Wiring
crates/common/Cargo.toml		 Switched lock_api, siphasher, and num-complex dependency entries to workspace-managed form: { workspace = true }.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ShaharNaveh
  • youknowone

Poem

🐰
I hopped through manifests in the night,
Added locks and sips with gentle bite,
Workspace one keeps versions tight,
Dependencies snug — a coder's delight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: moving dependencies from the common crate to the workspace, which aligns with both commit messages and the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fanninpm
Copy link
Copy Markdown
Contributor Author

fanninpm commented May 4, 2026

CI fails because @ShaharNaveh broke it in #7764.

@fanninpm fanninpm force-pushed the move-deps-to-workspace-for-common branch from 1e9bc0d to 0ee5db4 Compare May 5, 2026 00:55
@youknowone youknowone merged commit e4d35b0 into RustPython:main May 5, 2026
21 checks passed
@fanninpm fanninpm deleted the move-deps-to-workspace-for-common branch May 6, 2026 01:12
This was referenced May 13, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanninpm @youknowone