You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR modifies dependency tracking in scripts/update_lib/. The quick() function now returns a list of collected paths (data directories and hard dependencies) instead of None, enabling callers to extend their dependency lists. Meanwhile, deps.py refines import resolution logic to skip test_ modules during extraction and unifies non-test import path resolution.
Changes
Cohort / File(s)
Summary
Quick function return value scripts/update_lib/cmd_quick.py
Changed quick() return type from None to list[pathlib.Path]. Introduced internal extra_paths accumulator to collect migrated dependencies and copied data directories. Updated docstring and propagated return value to callers, which now extend hard_deps_for_commit with collected paths.
Modified test dependency extraction to skip imports from test\_ modules entirely, delegating them to separate update_lib entries. Unified non-test import path resolution using a single lookup with fallback, removing previous branching logic between test and support module handling.
Improve deps output #6874: Refactors the same cmd_quick.py file, including the quick function and its call sites.
Suggested reviewers
moreal
ShaharNaveh
Poem
🐰 Dependencies now hop back home, Paths collected, no more to roam, Quick returns what it finds, Tests skip their own kinds, A cleaner update_lib zone! 🌟
✨ Finishing touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes