Conversation
iddm
force-pushed
the
2610-fix-creating-indexes-with-a-list-of-labels
branch
from
November 17, 2022 11:30
5b8873c to
92add67
Compare
Previously, a list of labels was allowed in the query but never validated properly and the strings weren't extracted from the list. This commit parses the list of strings and so creates indexes for each label in the list as intended. Resolves: RedisGraph#2610
iddm
force-pushed
the
2610-fix-creating-indexes-with-a-list-of-labels
branch
from
November 17, 2022 11:31
7b0f8a7 to
f3205f5
Compare
Codecov ReportBase: 92.41% // Head: 92.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2714 +/- ##
==========================================
+ Coverage 92.41% 92.45% +0.03%
==========================================
Files 263 263
Lines 25035 25067 +32
==========================================
+ Hits 23137 23175 +38
+ Misses 1898 1892 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a list of labels was allowed in the query but never validated properly and the strings weren't extracted from the list.
This commit parses the list of strings and so creates indexes for each label in the list as intended.
Resolves: #2610