Skip to content

Integrate vscode-r-lsp - #695

Merged
renkun-ken merged 7 commits into
masterfrom
r-lsp
Jul 20, 2021
Merged

renkun-ken merged 7 commits into
masterfrom
r-lsp

Conversation

@renkun-ken

@renkun-ken renkun-ken commented Jul 2, 2021

Copy link
Copy Markdown
Member

Closes #691

  1. Disable vscode-r-lsp
  2. Open an R project and everything should behave in the same way with using vscode-r-lsp.

@ElianHugh

Copy link
Copy Markdown
Collaborator

Tested on WSL (Ubuntu) and everything seems to work nicely as before. No errors in dev console or output channel either

@renkun-ken
renkun-ken requested review from Ikuyadeu and randy3k July 14, 2021 10:14
@renkun-ken

Copy link
Copy Markdown
Member Author

@randy3k @Ikuyadeu Do you think we could merge this PR before the next release to the marketplace?

@Ikuyadeu

Copy link
Copy Markdown
Member

We haven't released it since I moved from Ikuyadeu.
I think that there is no problem once we check the display of the Marketplace.

@randy3k

randy3k commented Jul 15, 2021

Copy link
Copy Markdown
Member

How are we going to deprecate vscode-r-lsp?

@renkun-ken

Copy link
Copy Markdown
Member Author

How are we going to deprecate vscode-r-lsp?

Now before vscode-R starts the language server, it checks if vscode-r-lsp is enabled. If so, vscode-R does not start the language server and advice the user to uninstall vscode-r-lsp.

Then I'll add a visible note to the README of vscode-r-lsp saying that the extension has been merged into vscode-R and will be unpublished at some point. Some time later, we could officially unpublish vscode-r-lsp and no user could search or install it from within vscode extensions panel.

Comment thread README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate vscode-r-lsp into vscode-R

5 participants