Skip to content

Update the man help file used in packaging - #5173

Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
daxian-dbw:manfile
Oct 19, 2017
Merged

Update the man help file used in packaging#5173
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
daxian-dbw:manfile

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Oct 19, 2017

Copy link
Copy Markdown
Member

Update the man help file to reflect the name change.
I only changed the executable name. I think we should continue to use PowerShell in the rest of file

After this change, you will get No manual entry for powershell when running man powershell.
This is how it looks like when running man pwsh
image

adityapatwardhan
Aditya Patwardhan (adityapatwardhan) reviewed Oct 19, 2017
View reviewed changes
Comment thread .gitignore
# generated man files
/assets/powershell.1*

# resgen output

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Oct 19, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need /assets/pwsh.1* here?

@daxian-dbw Dongbo Wang (daxian-dbw) Oct 19, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it. New-UnixPackage command will clean up the generated pwsh.1.gz file in the end.

adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 19, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 2fd484f into PowerShell:master Oct 19, 2017
@iSazonov

Ilya (iSazonov) commented Oct 20, 2017 •
edited
Loading

Copy link
Copy Markdown
Collaborator

We should fix in ManagedEntranceStrings.resx:

 powershell /h

Usage: powershell[.exe] [[-File] <filePath> [args]]
                        [-Command { - | <script-block> [-args <arg-array>]
                                      | <string> [<CommandParameters>] } ]
                        [-ConfigurationName <string>] [-EncodedCommand <Base64EncodedCommand>]
                        [-ExecutionPolicy <ExecutionPolicy>] [-InputFormat {Text | XML}]
                        [-Interactive] [-NoExit] [-NoLogo] [-NonInteractive] [-NoProfile]
                        [-OutputFormat {Text | XML}] [-Version] [-WindowStyle <style>]

       powershell[.exe] -h | -Help | -? | /?

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Oct 20, 2017

Copy link
Copy Markdown
Member Author

Good catch. I will submit a PR shortly.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @adityapatwardhan
Update the man help file used in packaging (PowerShell#5173)
0d2a6d8 
* Update pacakging.psm1 and rename man file

* Update pwsh.1.ronn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daxian-dbw @iSazonov @SteveL-MSFT @adityapatwardhan