fix instantiation of key types and key_type_from_name - #34
Merged
Conversation
pkittenis
requested changes
Dec 1, 2020
Contributor
Author
|
Good points, I redid the change using cdefs and added a test for this. |
pkittenis
requested changes
Dec 4, 2020
Member
|
Looks great, thanks for making these changes. Couple more minor points in review. |
Member
|
Thanks for the contribution. 👍 Added another test for keygen which we did not have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_type = ...simply isn't allowed on a cdef field, so things got awkward). Due to this, just doing "keytypes.RSAKey()" and using that object as a key type would always fail. This is now fixed. E.g.key.generate(keytypes.RSAKey(), 4096)works now.(eref 42d478fb6976)