fix(jlink): drop jdk.jlink from includeAllModules runtime images (#673) - #682
Merged
Merged
Conversation
JEP 493 JDKs (Temurin 24+ and other builds without jmods/) refuse to link an image that contains jdk.jlink. includeAllModules copied `java --list-modules` verbatim, which includes it. A shipped app never needs jlink, so filter it out before --add-modules. The default module list never contained it, so default packaging is unchanged.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #673 (close by hand after merge: the base is
nucleus-2.6, not the default branch).Problem
On a JEP 493 JDK (Temurin 24+ and other builds without
jmods/),jlinkrefuses to emit an image containingjdk.jlink:nativeDistributions.includeAllModules = truecopiedjava --list-modulesverbatim, which includesjdk.jlink.Fix
AbstractJLinkTaskfiltersjdk.jlinkout of the module list before--add-modules. A shipped app never needs jlink. The default module list never contained it, so default packaging is unchanged.Verification
compileKotlinandktlintCheckpass on JDK 21.