ci: run template tests on macos-15 with the current Node LTS - #248
Merged
Merged
Conversation
macos-12 was retired, so every run queued forever waiting for a runner that no longer exists. Node 16 predates the NativeScript 9.1 and TypeScript 6 toolchain the templates now use.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A first job diffs the push against its base (the previous tip on main, the merge-base with main elsewhere) and feeds the affected templates to the build matrix. Shared inputs rebuild everything; Markdown-only changes build nothing.
Angular 19 made components standalone by default, so after the move to Angular 22 the drawer, tab and master-detail templates failed to build with NG6008 for every component their modules declare. Each of the three templates is bumped a patch.
…plate Angular 22 type-checks templates: the door selector binds a number and a number array to inputs typed as strings, and the list tap event from a custom element is typed as Event.
Android needs nothing from macOS, so it moves to ubuntu runners where it neither costs macOS minutes nor queues behind the five-runner cap. The npm cache is keyed on the template's own package.json instead of the repo root lockfile, which the created app never installs from.
The ubuntu image has the SDK but not the emulator package; the check treats that as fatal although compilation does not need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test workflow has not run since GitHub retired the
macos-12image: jobs requesting it never fail, they queue until cancelled, which is what every recent run of it shows (including on #247).runs-on: macos-12→macos-1516→lts/*; the templates are on NativeScript 9.1 and TypeScript 6, which need Node 20+checkout,setup-node,setup-java,setup-python,cachebumped to their current majors (checkout v7, setup-node v7, setup-java v6, setup-python v7, cache v5), which run on Node 24; the v2 and v4 versions target runtimes GitHub has deprecatedfail-fast: false, so one broken template no longer cancels the other 21 jobsconcurrencywithcancel-in-progress, so a newer push to the same branch cancels the run still going for the old oneubuntu-latest, iOS onmacos-15, as one template × platform matrix; the macOS jobs no longer pay for the Android build, and Linux jobs do not queue behind the five-concurrent macOS cappackage.json, so thenpm installof the created app hits the cache instead of the root-lockfile cache that never matched itchangesjob computes the matrix from the diff: only templates whose files changed are built, anything shared (shared-mobile,prepareTemplates.js, root package files, the workflow) builds all of them, Markdown-only pushes build none. On main it diffs against the previous tip, elsewhere against the merge-base with main. Vision and Solid templates stay out of the matrix as before.The first full run on this branch surfaced two pre-existing template breakages from the NativeScript 9.1 / Angular 22 upgrade in #245:
template-drawer-navigation-ng,template-tab-navigation-ngandtemplate-master-detail-ngfailed atns build ioswith NG6008 for every component still declared in anNgModule. Fixed here: the 18 declared components getstandalone: false, and the three templates are bumped to 9.1.1.template-master-detail-vue(Vue 2,nativescript-vue@~2.9.3) fails to compile against@nativescript/core9: webpack resolves core to a module exporting almost nothing. Left as is; whether to fix or retire the Vue 2 template is a separate call.🤖 Generated with Claude Code