chore(text-view): refactor ios for easy subclassing - #8663
Merged
NathanWalker merged 1 commit intoJun 24, 2020
Merged
Conversation
dosomder
force-pushed
the
text-view-ios-subclassing
branch
from
June 22, 2020 16:33
58fd5c8 to
9d17f5b
Compare
NathanWalker
self-requested a review
June 24, 2020 02:54
NathanWalker
approved these changes
Jun 24, 2020
Contributor
|
Nice work again @dosomder thank you 🙏 |
Contributor
|
Released with https://github.com/NativeScript/NativeScript/releases/tag/6.5.9 now |
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
tarunama
pushed a commit
to tarunama/NativeScript
that referenced
this pull request
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As done in #8514 for the text-field this PR refactors ios text-view so that methods can be overriden in own implementations.