fix(tabs): dynamic styling fixes - #8479
Merged
Merged
Conversation
selectedItemColor and unSelectedItemColor
vtrifonov
force-pushed
the
trifonov/dynamic-styling-fixes
branch
from
March 31, 2020 13:03
c4bb267 to
15a9df1
Compare
vmutafov
approved these changes
Apr 1, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* fix(tabs): dynamic styling fixes - iconSource selectedItemColor and unSelectedItemColor * fix(tabs): bottom nav item color fix * chore: remove unneeded method calls * chore: remove unneeded console.log * fix: fixing build * fix(tabs): resources passing * fix(tabs): setting item colors * test: updated dynamic color tests * chore: fix automationText
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* fix(tabs): dynamic styling fixes - iconSource selectedItemColor and unSelectedItemColor * fix(tabs): bottom nav item color fix * chore: remove unneeded method calls * chore: remove unneeded console.log * fix: fixing build * fix(tabs): resources passing * fix(tabs): setting item colors * test: updated dynamic color tests * chore: fix automationText
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Fixed dynamically setting
iconSourceof TabStripItem in Tabs/Bottom Navigation andselectedItemColor/unSelectedItemColorof TabStrip