fix: check is disposed fragment is in the FragmentManager - #8166
Closed
vakrilov wants to merge 7 commits into
Closed
fix: check is disposed fragment is in the FragmentManager#8166vakrilov wants to merge 7 commits into
vakrilov wants to merge 7 commits into
Conversation
vakrilov
force-pushed
the
dispose-fragment-crash
branch
from
December 4, 2019 12:52
8959c8c to
a75397a
Compare
vakrilov
marked this pull request as ready for review
December 5, 2019 07:37
vmutafov
self-requested a review
December 5, 2019 08:36
Collaborator
|
@vakrilov 4 things we can do and still be safe with different androidx versions :
|
vakrilov
force-pushed
the
dispose-fragment-crash
branch
2 times, most recently
from
December 6, 2019 14:43
3f812e1 to
37866cf
Compare
vakrilov
force-pushed
the
dispose-fragment-crash
branch
from
December 6, 2019 14:44
37866cf to
b20ec86
Compare
Contributor
Author
|
test |
vmutafov
approved these changes
Dec 16, 2019
5 tasks
Contributor
Author
|
closing in favor of #8201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Fragment is always removed from the fragment manager in the
Frame.disposeCurrentFragment()method. Different versions of androidX behave differently if you try to remove a fragment from a fragment manager.What is the new behavior?
Added a check if the current fragment is actually contained in the fragment manager returned by the
_getFragmentManager()Fixes #8037