fix(android): Proper change of input interaction mode programmatically - #10434
Merged
NathanWalker merged 2 commits intoNov 25, 2023
Merged
NathanWalker merged 2 commits into
NathanWalker merged 2 commits into
Conversation
CatchABus
marked this pull request as ready for review
November 9, 2023 22:15
NathanWalker
approved these changes
Nov 25, 2023
CatchABus
added a commit
to CatchABus/NativeScript
that referenced
this pull request
Apr 11, 2024
…matically (NativeScript#10434)" This reverts commit 07d2129.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There are times when we want to change the interaction of android input elements programmatically. Right now, re-enabling interaction programmatically has no effect.
What is the new behavior?
Android input interaction becomes programmatically toggleable without problems.
That goes for both
editableandisUserInteractionEnabledproperties.Fixes #8498.
Fixes #8523 in an alternate way by letting programmatic change of
editableto apply at the same time.