Address mistakes in inline functions cpp - #4872
Merged
Courtney Wales (Court72) merged 1 commit intoJan 17, 2024
Merged
Courtney Wales (Court72) merged 1 commit into
Courtney Wales (Court72) merged 1 commit into
Conversation
Contributor
|
Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit 8016acc: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
PRMerger Results
|
Contributor
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
Tyler Whitney (TylerMSFT)
approved these changes
Jan 17, 2024
Tyler Whitney (TylerMSFT)
left a comment
Collaborator
There was a problem hiding this comment.
Good stuff - thanks Rageking8!
Collaborator
|
#sign-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4871
Tidy up some of the earlier examples, augmented the multiply example to be more explicit about the differences when using a function macro like a proper function. For the last example, there seems to be UB with
sqr(c++)which expands to((c++) * (c++)), hence I wrapped it away into a function and added the part about the inline functionsquare.