Skip to content

fixed broken links for code examples - #4309

Closed
vedmin wants to merge 1 commit into
MicrosoftDocs:mainfrom
vedmin:patch-1
Closed

fixed broken links for code examples#4309
vedmin wants to merge 1 commit into
MicrosoftDocs:mainfrom
vedmin:patch-1

Conversation

@vedmin

@vedmin vedmin commented Nov 28, 2022

Copy link
Copy Markdown

Fixed broken links for code examples of asynchronous operations in C++.

@vedmin
fixed broken links for code examples
c19e954 
Fixed broken links for code examples of asynchronous operations in C++.
@prmerger-automator

prmerger-automator Bot commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

vedmin : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld30

opbld30 commented Nov 28, 2022

Copy link
Copy Markdown

Learn Build status updates of commit c19e954:

✅ Validation status: passed

File Status Preview URL Details
docs/parallel/concrt/creating-asynchronous-operations-in-cpp-for-windows-store-apps.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Court72

Courtney Wales (Court72) commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Tyler Whitney (@TylerMSFT)

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Nov 28, 2022
@TylerMSFT

Tyler Whitney (TylerMSFT) commented Nov 28, 2022

Copy link
Copy Markdown
Collaborator

vedmin, Hi, thank you for caring about the docs. I'm puzzled by the change because our filesystem isn't case-sensitive and I don't see a problem with the existing links. Can you explain what you are seeing that led you to make these changes?

TylerMSFT
Tyler Whitney (TylerMSFT) requested changes Mar 9, 2023
View reviewed changes

@TylerMSFT Tyler Whitney (TylerMSFT) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, these changes aren't necessary. The links aren't case-sensitive and we use lowercase.

@TylerMSFT

Tyler Whitney (TylerMSFT) commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

Asked for clarification in November, but didn't hear back. I don't believe this change is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerMSFT Tyler Whitney (TylerMSFT) TylerMSFT requested changes

Assignees

@TylerMSFT Tyler Whitney (TylerMSFT)

Labels

aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-concrt/tech do-not-merge qualifies-for-auto-merge visual-cpp/prod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vedmin @opbld30 @Court72 @TylerMSFT