Skip to content

Fix printing streampos to ostream - #2514

Closed
Christopher Yeleighton (yecril71pl) wants to merge 1 commit into
MicrosoftDocs:masterfrom
yecril71pl:patch-2
Closed

Fix printing streampos to ostream#2514
Christopher Yeleighton (yecril71pl) wants to merge 1 commit into
MicrosoftDocs:masterfrom
yecril71pl:patch-2

Conversation

@yecril71pl

@yecril71pl Christopher Yeleighton (yecril71pl) commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

The expression cout << y works as described only if no shift operator of streampos into ostream is defined. That operator may be defined by user code and the result may be different.

@yecril71pl
Fix printing streampos to ostream
d789eb3 
The expression (cout << y) works as described only if no shift operator of streampos into ostream is defined.  That operator may be defined by user code and the result may be different.
@PRMerger16

PRMerger16 commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Christopher Yeleighton (@yecril71pl) : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver Kristine Toliver (ktoliver) added the aq-pr-triaged Tracking label for the PR review team label Oct 5, 2020
@TylerMSFT

Tyler Whitney (TylerMSFT) commented Oct 5, 2020

Copy link
Copy Markdown
Collaborator

Hi Chris,
That's true, but I think it's apparent. And it complicates the mainline case. I'd rather not make this change.

@yecril71pl

Christopher Yeleighton (yecril71pl) commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

Hi Chris,
That's true, but I think it's apparent. And it complicates the mainline case. I'd rather not make this change.

For me the mainline case is that being able to say cout << y means it is also possible to say cin >> y, and if that is not possible, it is worth to indicate this fact somehow.

CaseyCarter
Casey Carter (CaseyCarter) suggested changes Nov 5, 2020
View reviewed changes
Comment thread docs/standard-library/ios-typedefs.md
@TylerMSFT

Tyler Whitney (TylerMSFT) commented Nov 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I've made this change to the topic and it will be live by Monday.

@TylerMSFT

Tyler Whitney (TylerMSFT) commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator

Closing because I made the updates from Casey in another branch.

@yecril71pl

Christopher Yeleighton (yecril71pl) commented Nov 9, 2020

Copy link
Copy Markdown
Contributor Author

I've made this change to the topic and it will be live by Monday.

It is Monday and it is not live.

opbld15 pushed a commit that referenced this pull request Nov 9, 2020
TylerMSFT TylerMSFT
address github #2514
ae1faf8
opbld15 pushed a commit that referenced this pull request Nov 9, 2020
@v-dihans
Merge pull request #3267 from TylerMSFT/twhitney-github2514
9b98cdd 
address github #2514
@TylerMSFT

Tyler Whitney (TylerMSFT) commented Nov 9, 2020

Copy link
Copy Markdown
Collaborator

Christopher Yeleighton (@yecril71pl) - I checked and it's live. Perhaps try refreshing the page in your browser.

@colin-home

Colin Robertson (colin-home) commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

Christopher Yeleighton (@yecril71pl) Publishing usually happens between 10 and 11 AM Redmond time (so, usually by 1900 UTC) on weekdays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerMSFT Tyler Whitney (TylerMSFT) Awaiting requested review from TylerMSFT
1 more reviewer
@CaseyCarter Casey Carter (CaseyCarter) CaseyCarter requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TylerMSFT Tyler Whitney (TylerMSFT)

Labels

aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-standard-libraries/tech do-not-merge visual-cpp/prod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yecril71pl @PRMerger16 @TylerMSFT @colin-home @CaseyCarter @ktoliver