fix: expose bundled Node.js to installer subprocesses - #115
Open
HP-network wants to merge 1 commit into
Open
HP-network wants to merge 1 commit into
HP-network wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the installer runs
npm installwith a bundled Node.js located under/opt/mcsmanager, npm lifecycle scripts inherit the caller's PATH. On clean systems this can producenode: not found, even though the installer itself can invoke the absolute Node.js path.Add the managed Node.js
bindirectory to PATH after Node.js setup in both language variants. This also makes the generated systemd unit expose the same path to the service.Fixes MCSManager/MCSManager#2338
Checks:
bash -n setup.sh setup_cn.sh${node_path}/binbefore component installation.