Skip to content

Add move_rows() to query.py - #73

Merged
cnathe merged 2 commits into
developfrom
fb_moveRowsPythonAPI
Jan 9, 2024
Merged

cnathe merged 2 commits into
developfrom
fb_moveRowsPythonAPI

Conversation

@cnathe

@cnathe cnathe commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Rationale

Related PR added a query-moveRows.api to the QueryController so that we could consolidate the various move entities actions to a single action. This PR adds move_rows() to the package.

Related Pull Requests

Changes

  • add move_rows() to query.py

@cnathe
cnathe requested a review from labkey-alan January 3, 2024 16:44
Comment thread CHANGE.txt Outdated

@labkey-alan labkey-alan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we may want to consider adding an integration test for this, and the release notes should be moved under the 3.0.0 section since this will be part of that release.

@cnathe

cnathe commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

Looks good to me, we may want to consider adding an integration test for this, and the release notes should be moved under the 3.0.0 section since this will be part of that release.

Adding an integration test would be great, but I don't know this package and the setup for that well enough to do it on my own. Could you help me out with that? I believe we'd need to 1) create a sample type or data class domain in container A 2) insert a row into that domain 3) create a child or sibling container that has the domain in scope 4) try the move_rows()

@cnathe
cnathe merged commit 9ca4601 into develop Jan 9, 2024
@cnathe
cnathe deleted the fb_moveRowsPythonAPI branch January 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving entities between projects - API dev - labkey-api-python

3 participants