Skip to content

test(types): remove Any from log test double - #280

Merged
swkeever merged 1 commit into
mainfrom
skeever/python-typed-log-double
Sep 22, 2026
Merged

swkeever merged 1 commit into
mainfrom
skeever/python-typed-log-double

Conversation

@swkeever

Copy link
Copy Markdown
Collaborator

The log test transport no longer uses explicit Any for response payloads, captured calls, or keyword arguments. A deliberately invalid list request now lives in the checked invalid-argument fixtures, keeping the runtime rejection test without a cast in handwritten test code.

Validation: uv run --locked poe quality (1,778 tests; 100% runtime line and branch coverage), targeted mypy --disallow-any-explicit, basedpyright, Ruff, and formatting.

@swkeever

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-22T22:56:18.166936Z e334fdd Manual request
🔒 Security Review Completed 2026-09-22T22:56:53.883815Z e334fdd Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: e334fdd35e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: e334fdd35e

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@swkeever
swkeever marked this pull request as ready for review September 22, 2026 22:59
@swkeever
swkeever requested a review from a team as a code owner September 22, 2026 22:59
@swkeever
swkeever merged commit 182e4ee into main Sep 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant