Skip to content

Fixed authorizations api - #245

Closed
GrahamCampbell wants to merge 1 commit into
masterfrom
unknown repository
Closed

GrahamCampbell wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@GrahamCampbell

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest renaming id to clientId to be more explicit about which id it is (the github doc describes it as client_id btw): https://developer.github.com/v3/oauth_authorizations/#check-an-authorization

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamCampbell rename please it would be clear

@stof

stof commented Feb 20, 2015

Copy link
Copy Markdown
Contributor

Resetting an authorization is also missing: https://developer.github.com/v3/oauth_authorizations/#reset-an-authorization

@cursedcoder

Copy link
Copy Markdown
Contributor

done by #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants