Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .idea/WebSocket-Node.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/encodings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/inspectionProfiles/Project_Default.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

78 changes: 78 additions & 0 deletions .idea/markdown-navigator.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions .idea/markdown-navigator/profiles_settings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion .npmignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
.npmignore
.gitignore
.git/
.DS_Store
.lock-*
node_modules/
docs/
example/
build/
builderror.log
npm-debug.log
test/
node_modules/
17 changes: 17 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
env:
- INTRAVENOUS=yes

os:
- linux

branches:
only:
- master

language: node_js
node_js:
- "10"
- "12"

script: "npm run test"
after_failure: "cat /home/travis/build/happner/happner/npm-debug.log"
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
Changelog
=========

Version 1.0.28 (SMC)
--------------------
*Released to SMC 2019-06-04*

* [SMC] Revert workaround for accepting/rejecting a websocket twice

Version 1.0.27 (SMC & Upstream)
--------------
-------------------------------
*Released to SMC 2019-02-11*
*Released 2018-09-19*

Expand Down
19 changes: 4 additions & 15 deletions lib/WebSocketRequest.js
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,7 @@ WebSocketRequest.prototype.parseCookies = function(str) {
};

WebSocketRequest.prototype.accept = function(acceptedProtocol, allowedOrigin, cookies) {
if (this._verifyResolution() == false){
return;
}
this._verifyResolution();

// TODO: Handle extensions

Expand Down Expand Up @@ -465,9 +463,7 @@ WebSocketRequest.prototype.accept = function(acceptedProtocol, allowedOrigin, co
};

WebSocketRequest.prototype.reject = function(status, reason, extraHeaders) {
if (this._verifyResolution() == false){
return;
}
this._verifyResolution();

// Mark the request resolved now so that the user can't call accept or
// reject a second time.
Expand All @@ -493,12 +489,7 @@ WebSocketRequest.prototype.reject = function(status, reason, extraHeaders) {
}

response += '\r\n';
try{
this.socket.end(response, 'ascii');
}
catch(err){
console.log(err);
}
this.socket.end(response, 'ascii');

this.emit('requestRejected', this);
};
Expand All @@ -515,10 +506,8 @@ WebSocketRequest.prototype._removeSocketCloseListeners = function() {

WebSocketRequest.prototype._verifyResolution = function() {
if (this._resolved) {
console.log(new Error('WebSocketRequest may only be accepted or rejected one time.'));
return false;
throw new Error('WebSocketRequest may only be accepted or rejected one time.');
}
return true;
};

function cleanupFailedConnection(connection) {
Expand Down
Loading