Refactor row count check for formatted CP Table rows to avoid collision - #5311
Merged
Merged
Conversation
…collision Issue: exp_file_manager_views has a columns field, and the CP Table library treats any row with a columns key as its internal format — count() then fails on the string rather than the expected format. Applying a fix to only use that format on the proper type of `columns`.
bryannielsen
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
exp_file_manager_viewshas a columns field, and the CP Table library treats any row with acolumnskey as its internal format —count()then fails on the string rather than the expected format. Applying a fix to only use that format on the proper type ofcolumns.Verify it here:
system.php?/cp/utilities/query/run-query/exp_file_manager_views&thequery=U0VMRUNUICogRlJPTSBleHBfZmlsZV9tYW5hZ2VyX3ZpZXdzNo documentation changes needed