three: fix SVGResult.xml type to SVGSVGElement - #75563
DanielGekeler wants to merge 1 commit into
Conversation
SVGLoader.parse() returns xml.documentElement from a DOMParser result, which is the parsed SVG root element, not an XMLDocument.
|
@DanielGekeler Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75563,
"author": "DanielGekeler",
"headCommitOid": "e4d1dc23146109d974615db519879b8f3ed6ddda",
"mergeBaseOid": "8bdaaa196899f9f2b986311cfe557c471940598b",
"lastPushDate": "2026-09-12T14:59:26.000Z",
"lastActivityDate": "2026-09-16T16:32:21.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "three",
"version": "0.186",
"kind": "edit",
"files": [
{
"path": "types/three/examples/jsm/loaders/SVGLoader.d.ts",
"kind": "definition"
},
{
"path": "types/three/test/unit/examples/jsm/loaders/SVGLoader.ts",
"kind": "test"
},
{
"path": "types/three/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"joshuaellis",
"Methuselah96"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "Methuselah96",
"date": "2026-09-14T18:39:04.000Z"
}
],
"mainBotCommentID": 5646671804,
"ciResult": "pass"
} |
|
🔔 @joshuaellis @Methuselah96 — please review this PR in the next few days. Be sure to explicitly select |
Methuselah96
left a comment
There was a problem hiding this comment.
Can you create a pull request for this over at https://github.com/three-types/three-ts-types where the types are maintained? Thanks!
|
@DanielGekeler One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Here you go: three-types/three-ts-types#2421 |
SVGLoader.parse()returnsxml.documentElementfrom aDOMParserresult, which is the parsed SVG root element, not anXMLDocument.Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in thepackage.json.Example