Conversation
|
@hkleungai Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 7 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71851,
"author": "hkleungai",
"headCommitOid": "1ef0a94cfe47c964d78f79a83c6715fba47a726a",
"mergeBaseOid": "58c738b2fd0d7550861c0422ebcaa022890841ea",
"lastPushDate": "2025-02-05T19:31:08.000Z",
"lastActivityDate": "2025-02-08T18:35:48.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/stream.ts",
"kind": "test"
},
{
"path": "types/node/v18/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/stream.ts",
"kind": "test"
},
{
"path": "types/node/v20/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/test/stream.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "Renegade334",
"date": "2025-02-08T15:10:14.000Z",
"abbrOid": "d2cd400"
}
],
"mainBotCommentID": 2637851070,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
47a05a9 to
d2cd400
Compare
|
It looks like someone converted the discussion to an issue – would you mind linking this to resolve #71850? |
d2cd400 to
1ef0a94
Compare
|
Seems I cannot link the issue by myself.
|
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Resolves #71828.
Resolves #71850
Also see my another PR on node repo, nodejs/node#56928.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition: