Conversation
1. TS 4.1 no longer has a built-in type named 'Position'. 2. TS 4.1 intentionally sets the global `name: void` to make it less usable. This flushed out a few bugs.
Not sure what broke, but node's had a lot of updates recently, so it was probably that.
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 47685,
"author": "sandersn",
"owners": [
"use-strict",
"rhonsby"
],
"dangerLevel": "ScopedAndUntested",
"headCommitAbbrOid": "59bfcf0",
"headCommitOid": "59bfcf0d85a971d13fce594c754919e23bdbe41f",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastPushDate": "2020-09-16T23:29:05.000Z",
"lastCommentDate": "2020-09-16T23:29:05.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47685/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Critical",
"newPackages": [],
"packages": [
"webpack-env"
],
"files": [
{
"path": "types/webpack-env/index.d.ts",
"kind": "definition",
"package": "webpack-env"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
|
🔔 @use-strict @rhonsby — please review this PR in the next few days. Be sure to explicitly select |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
|
duplicate of #47516 |
Update webpack-env to be compatible with node again.
Not sure what broke, but node's had a lot of updates recently, so it was probably that.