Fix latent bugs and misleading errors in create_videos - #3468
Merged
Merged
Conversation
deruyter92
changed the base branch from
dev/tst-3.1-release
to
backup/dev-tst-3.1-release
August 31, 2026 08:57
`create_labeled_video` returns one result per collected video, in the order `collect_video_paths` resolves them - not one per path passed in. This commit aligns the error log for failed videos now
`collect_video_paths` is not only used for videos: some helpers call it with extensions=".h5" to enumerate analysis outputs. This commits adds and wires a flag to suppress the misleading warning that ".h5" is not a supported video format.
deruyter92
force-pushed
the
jaap/fix-create-video
branch
from
August 31, 2026 09:06
a67c577 to
a18ede6
Compare
deruyter92
marked this pull request as ready for review
September 7, 2026 07:07
C-Achard
reviewed
Sep 8, 2026
| overwrite=self.overwrite_videos.isChecked(), | ||
| ) | ||
| if all(videos_created): | ||
| analyzed_videos = collect_video_paths(videos) |
Collaborator
There was a problem hiding this comment.
Should this filter by extension in case the folder has more than one supported video type?
Collaborator
Author
There was a problem hiding this comment.
videos comes from the GUI file picker and is an explicit file list rather than a directory path.
So here collect_video_paths(videos) just normalizes the selected files in the same way that the create_labeled_videos() backend does. (Both use the default SUPPORTED_VIDEO_EXTENSIONS) So I don’t think extra filtering is helpful here. Unless I'm overlooking something or didn't understand your comment correctly.
C-Achard
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent testing of the dev branch before 3.1 release undisclosed a few minor bugs or misleading error messages. These are fixed in the current PR:
collect_videos(videos)and not the loggedvideos, which in some cases may have a different order or count).collect_videosemits a warning for unsupported video file formats, but we use the function internally for.h5files as well. This PR introduces a silencing flag to not warn in these cases.analyze_videos_converth5_to_csvto only work for.mp4videos this is now changed to all supported video types.