Skip to content

Fix LinkageError for CodeOrigin - #12545

Open
jpbempel wants to merge 2 commits into
masterfrom
jpbempel/fix-code-origin-linkageError
Open

Fix LinkageError for CodeOrigin#12545
jpbempel wants to merge 2 commits into
masterfrom
jpbempel/fix-code-origin-linkageError

Conversation

@jpbempel

@jpbempel jpbempel commented Sep 17, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Member

What Does This Do

Avoid trying to transform classes already loading. SymDB transformer and DebuggerTransformer should skip packages from the debugger itself Prevent duplicated class definiton

Motivation

Additional Notes

relates to #10803

Contributor Checklist

Jira ticket: DEBUG-6214

@jpbempel
Fix LinkageError for CodeOrigin
fa41c42 
Avoid trying to transform classes already loading. SymDB transformer
and DebuggerTransformer should skip packages from the debugger itself
Prevent duplicated class definiton
@jpbempel
jpbempel requested a review from a team as a code owner September 17, 2026 12:26
@jpbempel
jpbempel requested review from evanchooly and removed request for a team September 17, 2026 12:26
@dd-octo-sts

dd-octo-sts Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug fix Bug fix labels Sep 17, 2026
datadog-datadog-us1-prod[bot]
datadog-datadog-us1-prod Bot reviewed Sep 17, 2026
View reviewed changes

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The shared package filter blocks debugger classes in both transformers. The unused imports are a format issue, not a run-time defect.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit fa41c42 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-us1-prod

This comment has been minimized.

Sign in to view
@pr-commenter

pr-commenter Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1789649994 1789650321
end_time 2026-09-17T13:01:24 2026-09-17T13:06:52
git_branch master jpbempel/fix-code-origin-linkageError
git_commit_sha 2e8be76 d3aa838
start_time 2026-09-17T12:59:55 2026-09-17T13:05:22
See matching parameters
Baseline Candidate
ci_job_id 2053294880 2053294880
ci_pipeline_id 138155426 138155426
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1789649215 1789649215

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+1.504ms; +1.847ms] or [+18.682%; +22.933%]		 worse
[+1.533ms; +1.876ms] or [+18.885%; +23.116%]		 worse
[+1.527ms; +1.868ms] or [+18.731%; +22.911%]		 worse
[+1.524ms; +1.865ms] or [+18.472%; +22.600%]		 worse
[-21.779op/s; -16.563op/s] or [-17.968%; -13.665%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-27.634µs; +35.652µs] or [-8.313%; +10.725%]		 unstable
[-39.805µs; +46.745µs] or [-10.858%; +12.751%]		 unstable
[-49.351µs; +59.215µs] or [-12.940%; +15.526%]		 unstable
[-136.371µs; +113.245µs] or [-12.350%; +10.256%]		 same
scenario:basic same same same unstable
[-230.060µs; +6.249µs] or [-23.068%; +0.627%]		 unstable
[-143.029op/s; +143.029op/s] or [-6.436%; +6.436%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (366.612 µs) : 328, 405
.   : milestone, 367,
basic (342.017 µs) : 335, 349
.   : milestone, 342,
loop (8.116 ms) : 8052, 8179
.   : milestone, 8116,
section candidate
noprobe (370.082 µs) : 327, 413
.   : milestone, 370,
basic (344.23 µs) : 340, 349
.   : milestone, 344,
loop (9.82 ms) : 9604, 10036
.   : milestone, 9820,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 366.612 µs [327.894 µs, 405.329 µs]
basic 342.017 µs [335.257 µs, 348.777 µs]
loop 8.116 ms [8.052 ms, 8.179 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 370.082 µs [326.749 µs, 413.415 µs]
basic 344.23 µs [339.802 µs, 348.658 µs]
loop 9.82 ms [9.604 ms, 10.036 ms]

@dd-octo-sts

dd-octo-sts Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.83 s 14.76 s [-0.5%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent 13.66 s 13.71 s [-1.2%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 17.12 s 16.70 s [+1.7%; +3.3%] (significantly worse)
startup:petclinic:iast:Agent 17.04 s 17.03 s [-0.7%; +0.8%] (no difference)
startup:petclinic:profiling:Agent 16.79 s 17.03 s [-2.8%; +0.0%] (no difference)
startup:petclinic:sca:Agent 16.94 s 16.69 s [+0.8%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent 16.25 s 16.07 s [+0.1%; +2.1%] (maybe worse)

Commit: d3aa8384 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@jpbempel
jpbempel added this pull request to the merge queue Sep 18, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-18 14:42:00 UTC ℹ️ Start processing command /merge

2026-09-18 14:42:05 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-18 15:03:09 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for b56bd05:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-datadog-us1-prod datadog-datadog-us1-prod[bot] datadog-datadog-us1-prod[bot] left review comments
@evanchooly evanchooly evanchooly approved these changes

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: bug fix Bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpbempel @evanchooly