Skip to content

Make CI test log forwarding opt-in - #12534

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
bdu/ci-debug-logs-on-demand
Sep 17, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
bdu/ci-debug-logs-on-demand

Conversation

@bric3

@bric3 bric3 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Disables JUnit log forwarding by default. It can be enabled with [ci: DEBUG_LOGS] or DD_CIVISIBILITY_LOGS_ENABLED=true.

Tip

DD_CIVISIBILITY_LOGS_ENABLED is a documented env var of datadog-ci tool

Motivation

Keep verbose test output in GitLab artifacts without forwarding it to Datadog Logs by default.

Before
image

Over the last year, with increased PR, commit push rate rate and a wider test matrix, the logs in JUnit reports have increased significantly.

After
image

Additional Notes

The opt-in forwards all JUnit-captured output, as supported by datadog-ci. Also, logs are still available in the JUnit report that are available as job artifacts.

Contributor Checklist

@bric3 bric3 added comp: tooling Build & Tooling type: bug fix Bug fix tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Sep 16, 2026
@datadog-official

datadog-official Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 59.09% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 11db852 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)

Suite Status
Startup 🟡 warning

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.90 s 14.68 s [+0.6%; +2.4%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.73 s 13.78 s [-1.1%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 17.66 s 17.57 s [-0.3%; +1.3%] (no difference)
startup:petclinic:iast:Agent 17.54 s 17.67 s [-1.6%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 17.62 s 17.45 s [-0.4%; +2.4%] (no difference)
startup:petclinic:sca:Agent 17.69 s 17.37 s [+0.9%; +2.8%] (maybe worse)
startup:petclinic:tracing:Agent 16.56 s 16.73 s [-2.0%; +0.0%] (no difference)

Commit: 11db8528 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding a comment that the commit message must contain [ci: DEBUG_LOGS] exactly to set DD_CIVISIBILITY_LOGS_ENABLED=true. Otherwise LGTM

@bric3
bric3 force-pushed the bdu/ci-debug-logs-on-demand branch from 27effc2 to 11db852 Compare September 17, 2026 14:29
@bric3
bric3 marked this pull request as ready for review September 17, 2026 14:48
@bric3
bric3 requested review from a team as code owners September 17, 2026 14:48
@bric3
bric3 requested review from amarziali and erikayasuda and removed request for a team September 17, 2026 14:48
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-17T14:50:39.604624Z 11db852 Draft marked ready
🔒 Security Review Completed 2026-09-17T14:50:55.208985Z 11db852 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The upload keeps test results available and forwards captured logs only when the commit token or CI variable enables this function.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 11db852 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@bric3

bric3 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 17, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-17 15:56:36 UTC ℹ️ Start processing command /merge


2026-09-17 15:56:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-17 17:11:25 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit b9dbc3a into master Sep 17, 2026
608 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/ci-debug-logs-on-demand branch September 17, 2026 17:11
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants