Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
amarziali
force-pushed
the
andrea.marziali/diag2
branch
from
September 18, 2026 11:55
13947ba to
c034c2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Extends the default continuation-leak diagnostics to suite-level test fixtures:
setupSpec()andcleanupSpec()@BeforeAlland@AfterAllThis closes the diagnostic window around work created before the first test or cleaned up after the last test. Reports identify whether a failure belongs to suite setup, an individual test, or suite cleanup.
Class-level
@TrackScopeContinuationsconfiguration applies to suite fixtures. The investigation skill has also been updated to describe the expanded coverage.flowchart LR A["Harness initializes tracer"] --> B["Suite setup<br/>setupSpec / @BeforeAll"] B --> C["Per-test diagnostics"] C --> D["Suite cleanup<br/>cleanupSpec / @AfterAll"] D --> E["Harness closes tracer"] B -. "report suite setup leaks" .-> F["Diagnostic report"] C -. "report test leaks" .-> F D -. "report suite cleanup leaks" .-> FMotivation
Continuation work created in suite fixtures previously fell outside the per-test diagnostic window. This could hide lifecycle problems caused during shared fixture initialization or shutdown.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]