What Does This Do

Widens datadog.trace.api.function.NoEscape (added in #12368) from @Target(TYPE) to @Target({TYPE, METHOD}), and extends its Javadoc "Checker contract" with a matching method-form trigger.

Motivation

The type form only works when the returned value's concrete type can itself carry the annotation (e.g. SubSequence, Maybe). It can't when the return type is a lambda or anonymous instance of a JDK interface — Iterable, Iterator, Runnable, etc — which we can't annotate. That's exactly the shape of ConcurrentHashtable.hashIterable/hashIterator (in a companion branch), which return () -> hashIterator(...)-style lambdas that should never be retained past the scan that consumes them.

The two forms compose: annotate the type when you can, fall back to the method when you can't.

Additional Notes

• No behavior change — @NoEscape stays CLASS-retention, no runtime semantics.
• No new wearers of the method form in this PR; it's a prerequisite for a follow-up applying it to ConcurrentHashtable.hashIterable/hashIterator.
• Also updated the perf-review skill's checks.md entry to describe both trigger shapes.

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and comp: labels in addition to any other useful labels
• Avoid using close/fix/linking keywords when referencing an issue
• Update the CODEOWNERS file on source file addition, migration, or deletion (n/a — no new module/ownership boundary)
• Update public documentation with any new configuration flags or behaviors (n/a — internal-only marker annotation)
• Once approved, use merge queue to merge the PR

🤖 Generated with Claude Code