Skip to content

Preserve inherited Java tool options in CI - #12514

Draft
alee1246 wants to merge 1 commit into
masterfrom
alee1246/CIEXE/depot-attribution-id-token
Draft

Preserve inherited Java tool options in CI#12514
alee1246 wants to merge 1 commit into
masterfrom
alee1246/CIEXE/depot-attribution-id-token

Conversation

@alee1246

@alee1246 alee1246 commented Sep 15, 2026

Copy link
Copy Markdown

What Does This Do

Preserves inherited JAVA_TOOL_OPTIONS when debugger exploration tests and JUnit console smoke tests add their own JVM arguments.

Motivation

The GitLab Runner admission controller injects JVM trust-store and proxy settings through JAVA_TOOL_OPTIONS so Maven, Gradle, and child JVMs can reach Depot through the Envoy proxy. These test paths replaced the inherited value, removing that configuration.

Appending their test-specific options keeps the admission-controller settings while allowing the test arguments, which appear later, to retain JVM option precedence.

Additional Notes

The intentional JAVA_TOOL_OPTIONS removal in the agent-jar integration verification task and crash-upload tooling remains unchanged.

Validation performed:

  • Checked the debugger script with bash -n.
  • Verified append behavior under set -u with an inherited value.
  • Ran ./gradlew :dd-smoke-tests:junit-console:spotlessApply --no-daemon.
  • Ran git diff --check.

Contributor Checklist

  • Internal CI/test behavior only; no public API change.
  • No new source files or CODEOWNERS changes.
  • No public documentation changes required.

Jira ticket: N/A

@alee1246 alee1246 added comp: tooling Build & Tooling type: bug fix Bug fix tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Sep 15, 2026
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.08% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5cba8e7 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Sep 15, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1789501444 1789501771
end_time 2026-09-15T19:45:35 2026-09-15T19:51:02
git_branch master alee1246/CIEXE/depot-attribution-id-token
git_commit_sha 4c983f4 5cba8e7
start_time 2026-09-15T19:44:05 2026-09-15T19:49:32
See matching parameters
Baseline Candidate
ci_job_id 2046599325 2046599325
ci_pipeline_id 137673093 137673093
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1789500580 1789500580

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic worse
[+9.757µs; +26.507µs] or [+3.068%; +8.334%]		 worse
[+9.433µs; +26.515µs] or [+2.751%; +7.732%]		 worse
[+10.306µs; +26.605µs] or [+2.927%; +7.557%]		 unstable
[-167.422µs; +100.840µs] or [-18.306%; +11.026%]		 unstable
[-183.904op/s; +87.285op/s] or [-8.276%; +3.928%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-41.357µs; +37.437µs] or [-12.128%; +10.978%]		 unstable
[-57.479µs; +51.310µs] or [-15.241%; +13.605%]		 unstable
[-65.572µs; +61.758µs] or [-16.744%; +15.770%]		 unstable
[-172.495µs; +286.962µs] or [-14.840%; +24.688%]		 same
scenario:loop same same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (377.148 µs) : 324, 430
.   : milestone, 377,
basic (342.902 µs) : 336, 350
.   : milestone, 343,
loop (8.114 ms) : 8051, 8178
.   : milestone, 8114,
section candidate
noprobe (374.063 µs) : 324, 424
.   : milestone, 374,
basic (360.876 µs) : 352, 370
.   : milestone, 361,
loop (8.117 ms) : 8054, 8181
.   : milestone, 8117,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 377.148 µs [324.037 µs, 430.26 µs]
basic 342.902 µs [335.696 µs, 350.108 µs]
loop 8.114 ms [8.051 ms, 8.178 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 374.063 µs [323.933 µs, 424.194 µs]
basic 360.876 µs [351.627 µs, 370.125 µs]
loop 8.117 ms [8.054 ms, 8.181 ms]

@dd-octo-sts

dd-octo-sts Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.83 s 14.72 s [-0.2%; +1.7%] (no difference)
startup:insecure-bank:tracing:Agent 13.61 s 13.81 s [-2.1%; -0.8%] (maybe better)
startup:petclinic:appsec:Agent 17.65 s 17.46 s [+0.2%; +2.0%] (maybe worse)
startup:petclinic:iast:Agent 17.58 s 17.62 s [-1.0%; +0.6%] (no difference)
startup:petclinic:profiling:Agent 17.04 s 17.50 s [-7.2%; +2.1%] (no difference)
startup:petclinic:sca:Agent 17.54 s 17.56 s [-1.1%; +1.0%] (no difference)
startup:petclinic:tracing:Agent 16.40 s 16.60 s [-2.1%; -0.3%] (maybe better)

Commit: 5cba8e73 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alee1246