Skip to content

composer: require mockery/mockery ~1 - #13

Merged
enumag merged 1 commit into
Codeception:masterfrom
kornrunner:master
Oct 10, 2017
Merged

enumag merged 1 commit into
Codeception:masterfrom
kornrunner:master

Conversation

@kornrunner

Copy link
Copy Markdown
Contributor

Require stable version of mockery/mockery

Since upstream introduces BC breaks - it's likely that MockeryModule will also need a version bump.

@enumag

enumag commented Oct 10, 2017

Copy link
Copy Markdown
Member

Mockery 1.0 probably does not change anything for this module since the only thing we use is Mockery::close(); - that didn't change, right?

So the correct way to go here is to change the version constraint to ^0.8|^0.9|^1.0.

@kornrunner

Copy link
Copy Markdown
Contributor Author

As far as I can see - that did not change.

I can amend the PR with constraint you've suggested if you'd like. Thanks!

@enumag

enumag commented Oct 10, 2017

Copy link
Copy Markdown
Member

Please do. And change the commit message to something like "Allow Mockery 1.x". Thanks!

@enumag

enumag commented Oct 10, 2017

Copy link
Copy Markdown
Member

And I don't think we need to increase the version for this. 0.2.3 seems good enough to me. What do you think?

@kornrunner

Copy link
Copy Markdown
Contributor Author

Pushed changes as per our agreement.

Yeah, I agree - minor version bump should suffice in this case. Thank you!

@enumag
enumag merged commit d01f9d0 into Codeception:master Oct 10, 2017
@kornrunner

kornrunner commented Oct 11, 2017

Copy link
Copy Markdown
Contributor Author

Could you please do a manual update on https://packagist.org/packages/codeception/mockery-module as it's not seeing the new version yet. Thanks!

@enumag

enumag commented Oct 11, 2017

Copy link
Copy Markdown
Member

I don't have access there.

@DavertMik Can you solve it? And setup automatic updates for the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants