Manchester | 26-SDC-Jul | Fithi Teklom | Sprint 4 | Implement shell tools in Python - #672
Fithi-Teklom wants to merge 2 commits into
Conversation
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but I have a comment about one of the files.
For all of them,have you considered using a library or package to help you with argument parsing?
|
|
||
| output = [] | ||
|
|
||
| if count_lines: |
There was a problem hiding this comment.
it looks like there is some duplication in the structure of this code. Can you think of a way to simplify it?
There was a problem hiding this comment.
Yes , I have defined a function to avoid duplication of codes.
This comment has been minimized.
This comment has been minimized.
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, it's always worth looking for repeated code you can abstract into a function.
Could you answer the question in my earlier review please?
|
I was thinking about my earlier question about argument parsing - you are managing all the arguments yourself using sys.argv. Did you consider using a library at all for this task? |
Self checklist
Task code
CYF-1152
Changelist
Implemented shell tools (wc, cat, ls) using python